Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssl/bestrq] questions: Why do you use mask_emb? Why do you use regularization on input? #1997

Closed
SatenHarutyunyan opened this issue Sep 6, 2023 · 3 comments
Assignees

Comments

@SatenHarutyunyan
Copy link

Thank you for the implementation!

I have several questions about your bestrq code, and I would appreciate any clarifications.

  1. Why do you use mask_emb? The paper mentions that when masking the input, it replaces the masked frames with white noise. In your implementation, you are using a learnable tensor called mask_emb to replace the frames with.

    • What is the intuition behind this choice? Does it have something to do with the <MASK> token from BERT?
    • Does this approach work better than just adding random noise?
  2. Why do you use regularization on the input?

@Mddct Mddct self-assigned this Sep 7, 2023
@Mddct
Copy link
Collaborator

Mddct commented Sep 7, 2023

@SatenHarutyunyan
1 We have chosen to use random noise better than mask_emb, but no time to submit pr yet
2 L2 regularization is better than no l2 regularization 。 And the l2 loss function is a commonly used method to avoid overfitting

@SatenHarutyunyan
Copy link
Author

SatenHarutyunyan commented Sep 8, 2023

Thanks for answers.
2) Do I understand correctly that you set regularization on spectrogram directly (input) and there are no parameters to regularize? Wont the gradient be 0 on the regularization component of the loss?

@Mddct
Copy link
Collaborator

Mddct commented Sep 8, 2023

Using L2 regularization in the input can make the model less likely to over-rely on certain input features (mask noise), thereby improving the generalization performance of the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants