Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add]:Import, export button for teachers and syllabus creation is improved #36

Merged
merged 22 commits into from
Apr 27, 2023

Conversation

seramg
Copy link
Contributor

@seramg seramg commented Apr 21, 2023

close #30
close #35

@mak626 look into the syllabus creation. semester value by default while creation is 0

seramg and others added 16 commits March 25, 2023 19:13
This reverts commit 6a263d6.

Added Subject Names to teacher page

Added Subject Names to teacher page
1. Import button now checks for any matching record and overrides the content with the new data

2. on creation, the data already present is iterated and checked for any duplicate

3. data exported from auth teachers now doesn't have the created property

4. Added name validation which checks for presence of '.' and numbers

5.
note: the semesterData is initially set an object instead of it being undefined coz its causing an uncontrolled state
@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for attendo-admin ready!

Name Link
🔨 Latest commit e9f66f8
🔍 Latest deploy log https://app.netlify.com/sites/attendo-admin/deploys/6442c5e50c95250007d9269c
😎 Deploy Preview https://deploy-preview-36--attendo-admin.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mak626 mak626 changed the base branch from master to staging April 21, 2023 17:25
Copy link
Collaborator

@mak626 mak626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In additon to my changes. In the code give space between functions. Code readability is hard with no spaces b/w different functions

src/Utils/helpers.ts Outdated Show resolved Hide resolved
src/pages/authTeachers/Create.tsx Outdated Show resolved Hide resolved
src/pages/authTeachers/Show.tsx Outdated Show resolved Hide resolved
src/pages/authTeachers/Show.tsx Outdated Show resolved Hide resolved
src/pages/authTeachers/components/Button.tsx Outdated Show resolved Hide resolved
src/provider/custom/classroom.ts Outdated Show resolved Hide resolved
src/pages/subjects/index.tsx Show resolved Hide resolved
src/pages/subjects/components/show/SubjectTable.tsx Outdated Show resolved Hide resolved
src/pages/subjects/components/show/SubjectTable.tsx Outdated Show resolved Hide resolved
src/pages/subjects/components/show/SubjectTable.tsx Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Apr 23, 2023

Deploy Preview for attendo-admin-dev ready!

Name Link
🔨 Latest commit 84468bd
🔍 Latest deploy log https://app.netlify.com/sites/attendo-admin-dev/deploys/644abdf492d87700083b1f08
😎 Deploy Preview https://deploy-preview-36--attendo-admin-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/pages/authTeachers/Show.tsx Outdated Show resolved Hide resolved
src/Utils/helpers.ts Outdated Show resolved Hide resolved
@mak626 mak626 changed the title [add]:Import, export button for teachers and syllabus creation is improoved [add]:Import, export button for teachers and syllabus creation is improved Apr 23, 2023
@mak626 mak626 merged commit dec9990 into staging Apr 27, 2023
@mak626 mak626 deleted the teacherButton branch April 27, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants