Semantic Docker Tagging #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
force-pushed
the
new-docker-versions
branch
4 times, most recently
from
2ee13d0
to
80c6ba0
Compare
philsturgeon
force-pushed
the
new-docker-versions
branch
from
80c6ba0
to
e6cda75
Compare
swirsky
approved these changes
Jan 17, 2019
This was referenced Jan 17, 2019
Merged
johnbuhay
reviewed
Jan 18, 2019
| - run: | ||
| name: | ||
| command: | | ||
| docker_tag=$DOCKER_REPOSITORY:${CIRCLE_SHA1:0:7} |
There was a problem hiding this comment.
this ${CIRCLE_SHA1:0:7} has been identified as not working for 100% of shells, use $CIRCLE_SHA1 | cut -c1-7 instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the awesome semantic tagging approach @razvan-wework just used for another tool.