-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-miro is added in the resolved spec even after explicitly setting preserveMiro: false #268
Comments
In what file do you set the options? |
Calling speccy from typescript code like below and passing the option there. private static options = {
resolve: true, // Resolve external references
jsonSchema: true, // Treat $ref like JSON Schema and convert to OpenAPI Schema Objects
preserveMiro: false // Flag to resolver as to whether to preserve old value of $ref in x-miro
};
static async ResolveReferences(documentUrl: string)
{
return new Promise<string>(async (resolve,reject) => {
loader.loadSpec(documentUrl,SpeccyClient.options,(err,data ) => {
if (err) {reject(err);}
else {resolve(JSON.stringify(data));}
})
})
} |
I'm having this issue using the docker image as well. I don't think the x-miro extensions should be in a resolved spec at all. Default behaviour should be I was using Docker image |
I'm also experiencing this, plus the generated code goes against one of the lint rules: |
Anyone with a nice short input definition as a repro case? |
I have just added a new issue in oas-kit for this |
also having the same issue :( |
Fixed here Mermade/oas-kit#152 (comment) |
Using latest npm package of speccy and even after setting preserveMiro: false in options, seeing it added in resolved spec, when loading this spec in swagger editor its complaining about it.
The text was updated successfully, but these errors were encountered: