Mark wayland-backend as optional dependency #6342
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wez#6315 wez@09ac8c5 introduced the `wayland-backend` dependency, but did not mark it as optional, this prevented the build from successfully completing on X11 systems without Wayland development libraries.
wez
reviewed
Oct 31, 2024
| @@ -82,7 +82,7 @@ zbus = "4.2" | |||
| zvariant = "4.0" | |||
|
|
|||
| smithay-client-toolkit = {version = "0.19", default-features=false, optional=true} | |||
| wayland-backend = {version="0.3.5", features=["client_system", "rwh_06"]} | |||
| wayland-backend = {version="0.3.5", features=["client_system", "rwh_06"], optional=true} | |||
There was a problem hiding this comment.
I think you also need to add wayland-backend to the list of features up on line 18 for this to work correctly
There was a problem hiding this comment.
That would explain all of the build failure emails I got, updated!
By making `wayland-backend` optional, it broke the builds which used Wayland since it was never required by the `wayland` feature.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6315
09ac8c5 introduced the
wayland-backenddependency, but did not mark it as optional, this prevented the build from successfully completing on X11 systems without Wayland development libraries.This marks it as optional like the other Wayland dependencies and allows the builds with
--no-default-featureson systems without Wayland to build successfully, as tested on my system.