Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section on defining a new event #364

Open
annevk opened this issue Nov 3, 2016 · 2 comments
Open

Add a section on defining a new event #364

annevk opened this issue Nov 3, 2016 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented Nov 3, 2016

Needs to cover:

  • Brief description on inheritance of dictionaries and interfaces
  • Using present tense for Event/type
  • Event/type being all lowercase without hyphens
  • Pointers to "fire", "create", and "dispatch" (and handling return values of fire and dispatch)

Anything else?

(This might involve moving some information around. I'd rather not say the same twice.)

@dbaron
Copy link
Member

dbaron commented Nov 10, 2016

I guess the section on defining event interfaces means you've started this (although I didn't check history). (I got here from a blink-dev thread on constructors for WebAudio events.)

Possible other things:

  • having a constructor
  • whether to have onfoo DOM properties and (if target is an element) HTML attributes on the target
  • whether to add support for document.createEvent (no, I think). (You've already mentioned not introducing init*Event, and I think this goes along.)

@domenic
Copy link
Member

domenic commented Nov 10, 2016

Per #372 we need to make it clear there should be a 1:1 relation between the event init dict and the event's properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants