From 66e162f78e679ee99f1d6c6d15aa2672ca6dd943 Mon Sep 17 00:00:00 2001 From: Mirko Brodesser <129945747+mbrodesser-Igalia@users.noreply.github.com> Date: Thu, 29 Jun 2023 16:03:00 +0200 Subject: [PATCH] Editorial: change "show popover" to call "check popover validity" first This is what implementations (at least Gecko and Chromium) do and it's analogous to what happens in "hide popover". Fixes #9429. --- source | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/source b/source index 3dd0ab4b8e6..6b09c916fb6 100644 --- a/source +++ b/source @@ -82554,12 +82554,23 @@ dictionary DragEventInit : MouseEventInit { element or null invoker:
If the result of running check popover validity given element, + false, throwExceptions, and null is false, then return.
Let document be element's node document.
Assert: element's popover invoker is null.
Set element's popover invoker to invoker.
Assert: element is not in document's top + layer.
Let nestedShow be element's popover showing or + hiding.
Set element's popover showing or hiding to true.
Let cleanupShowingFlag be the following steps:
@@ -82569,20 +82580,6 @@ dictionary DragEventInit : MouseEventInit {If the result of running check popover validity given element, - false, throwExceptions, and null is false, then run cleanupShowingFlag and - return.
Assert: element is not in document's top - layer.
Let nestedShow be false.
If element's popover showing or hiding is true, then set - nestedShow to true.
Set element's popover showing or hiding to true.
If the result of firing an event named beforetoggle
, using ToggleEvent
, with the cancelable
attribute initialized to true, the