Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev edition: web worker doc example typo, nesting canvas elements #6388

Closed
susan51531 opened this issue Feb 14, 2021 · 2 comments
Closed

Dev edition: web worker doc example typo, nesting canvas elements #6388

susan51531 opened this issue Feb 14, 2021 · 2 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@susan51531
Copy link

Page: Using a JavaScript module as a worker

This code example appends a canvas to the existing canvas#output, which is not valid. Maybe replace canvas#output to div#output, or reusing canvas#output to paint the image without creating a new one every time.

-<canvas id="output"></canvas>
+<div id="output"></div>
@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Feb 15, 2021
@domenic
Copy link
Member

domenic commented Feb 16, 2021

Ah, yeah, this is a great find! I think in addition to the change you mention, we'd want to change output.appendChild(canvas) to output.replaceChildren(canvas).

A pull request fixing this would be welcome!

@satrujit11
Copy link
Contributor

Hey , i am a beginner and thanks for issue . i will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Development

No branches or pull requests

4 participants