Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting: use <code> instead of <span> in sentence about picture/img 'aspect-ratio' #6674

Closed
zcorpan opened this issue May 11, 2021 · 2 comments
Closed

Formatting: use <code> instead of <span> in sentence about picture/img 'aspect-ratio' #6674

zcorpan opened this issue May 11, 2021 · 2 comments
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@zcorpan
Copy link
Member

zcorpan commented May 11, 2021

https://html.spec.whatwg.org/multipage/embedded-content.html#the-source-element

The source element supports dimension attributes. These attributes can map to the aspect-ratio property as well as the rendered dimensions of sibling img element, if source element's parent is a picture element and source element's source set is returned as a result of update the source set for that sibling img.

"source", "picture", "img" are marked up with <span> but should be <code>
@zcorpan zcorpan added clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project labels May 11, 2021
@domenic
Copy link
Member

domenic commented May 11, 2021

I think this is being fixed in #6529

@zcorpan
Copy link
Member Author

zcorpan commented May 11, 2021

Ah, indeed. Great!

@zcorpan zcorpan closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @domenic