Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

titleBar and autocomplete selection color is red? #4

Closed
michaelroper opened this issue Sep 11, 2017 · 2 comments
Closed

titleBar and autocomplete selection color is red? #4

michaelroper opened this issue Sep 11, 2017 · 2 comments
Assignees
@whizkydee

Comments

@michaelroper
Copy link

michaelroper commented Sep 11, 2017 •
edited
Loading

Hey Olaolu!

Just found your theme, and really like it. I have noticed a couple of odd things though, namely the titleBar foreground and the autocomplete selected item colors are showing up as red (as in #ff0000 red). I went to try and do a fix+PR, but looking through the theme code, I can't see anywhere that the red color is specified... any ideas why it might be doing this? (VS Code v1.16.0, theme v1.2.0)

image
@whizkydee whizkydee self-assigned this Sep 11, 2017
@whizkydee
Copy link
Owner

Thanks @michaelroper ,

It's fixed now with that commit, and is included in the v1.3.0 release.

The bug was just so silly. Imagine, I wrote #eefff instead of #eeefff and #7e57c25 instead of #7e57c2.

Thanks a lot for the hint 👍

@michaelroper
Copy link
Author

Cheers Olaolu - it's looking good now! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizkydee whizkydee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelroper @whizkydee