From 5b52a62ab153ad2b06164b8b7904581869c3c96c Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 28 Nov 2019 23:42:12 -0800 Subject: [PATCH] test: move test-http-max-http-headers to parallel test-http-max-http-headers seems to run fine in parallel, even with `tools/test.py -j 96 --repeat 192 test/parallel/test-http-max-http-headers.js`. The same applies to `test-set-http-max-http-headers.js` which (as written) depends on `test-http-max-http-headers.js` being in the same directory. So that is being moved too. PR-URL: https://github.com/nodejs/node/pull/30712 Reviewed-By: David Carlier Reviewed-By: Luigi Pinca --- test/{sequential => parallel}/test-http-max-http-headers.js | 0 .../test-set-http-max-http-headers.js | 6 ++---- 2 files changed, 2 insertions(+), 4 deletions(-) rename test/{sequential => parallel}/test-http-max-http-headers.js (100%) rename test/{sequential => parallel}/test-set-http-max-http-headers.js (91%) diff --git a/test/sequential/test-http-max-http-headers.js b/test/parallel/test-http-max-http-headers.js similarity index 100% rename from test/sequential/test-http-max-http-headers.js rename to test/parallel/test-http-max-http-headers.js diff --git a/test/sequential/test-set-http-max-http-headers.js b/test/parallel/test-set-http-max-http-headers.js similarity index 91% rename from test/sequential/test-set-http-max-http-headers.js rename to test/parallel/test-set-http-max-http-headers.js index cfe1ed69537743..c4df779d2bd4fa 100644 --- a/test/sequential/test-set-http-max-http-headers.js +++ b/test/parallel/test-set-http-max-http-headers.js @@ -37,8 +37,7 @@ test(function(cb) { NODE_DEBUG: 'http' }); - // Validate that the test fails if the max header size is too small. - // Validate that the test now passes if the same limit becomes large enough. + // Validate that the test now passes if the same limit is large enough. const args = ['--expose-internals', '--max-http-header-size=1024', testName, @@ -76,8 +75,7 @@ if (!process.config.variables.node_without_node_options) { }); test(function(cb) { - // Validate that the test now passes if the same limit - // becomes large enough. + // Validate that the test now passes if the same limit is large enough. const args = ['--expose-internals', testName, '1024']; const cp = spawn(process.execPath, args, { env, stdio: 'inherit' });