-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle rewrite map collisions #44
Comments
Because packages like |
See #38 (comment) and the related discussion. |
Thanks for the reference. Performance issues aside, I think we should explicitly declare all the imports in If that can't be fixed at the moment I still think And as an extra, we could add a warning in |
When building the rewrite map (
buildRewriteMapping
) new entries for the sameDvcsImport
will overwrite the old ones, so if apackage.json
explicitly declares a dependency A with version 2.0 but another dependency B (processed later) also has a dependency to A but with an older 1.0 version, this older version will get rewritten, the root package will be using the old version even though it explicitly declared the new one.A first approach would be to prioritize dependencies in the
package.json
(over indirect dependencies), but I also have the doubt of why the map needs to go through the entire dependency tree to rewrite just the root package (I'm thinking of thegx install
scenario, where the rewrite -post-install
hook- will be called explicitly on every package separately).The text was updated successfully, but these errors were encountered: