Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS builds fail in CI workflow in dependency installation step #6335

Closed
bunnybot opened this issue Jan 30, 2024 · 2 comments
Closed

macOS builds fail in CI workflow in dependency installation step #6335

bunnybot opened this issue Jan 30, 2024 · 2 comments
Assignees
Labels
bug Something isn't working building & packaging Building, packaging, continuous integration, appdata, cmake macos Compiling and packaging for Apple urgent Needs to be fixed before the next release.
Milestone

Comments

@bunnybot
Copy link

bunnybot commented Jan 30, 2024

tothxaMirrored from Codeberg
Created on Wed Jan 31 00:15:18 CET 2024 by Tóth András (tothxa)


Describe the bug
It looks like we're starting to get random breakage in macOS builds in the dependency installation step. We should probably consider caching those similar to vcpkg.

Expected behavior
Stable workflow runs

@bunnybot bunnybot added bug Something isn't working building & packaging Building, packaging, continuous integration, appdata, cmake macos Compiling and packaging for Apple labels Jan 30, 2024
@tothxa tothxa changed the title Random breakage in CI workflow macOS dependency installation macOS builds fail in CI workflow in dependency installation step Jan 31, 2024
@tothxa tothxa added the urgent Needs to be fixed before the next release. label Jan 31, 2024
@tothxa tothxa added this to the v1.2 milestone Jan 31, 2024
@tothxa
Copy link
Member

tothxa commented Jan 31, 2024

Although the end of the logs shows a big scary deprecation warning for macos11, that's actually an old thing that didn't cause problems so far.

==> Installing graphviz dependency: libvmaf
==> meson build
==> ninja -vC build
Last 15 lines from /Users/runner/Library/Logs/Homebrew/libvmaf/02.ninja:
src/vmaf_v0.6.1.json.c:1595:1: error: unknown type name 'size_t'
size_t src_vmaf_v0_6_1_json_len = 19101;
^
1 error generated.
[42/165] clang -Isrc/liblibvmaf_feature.a.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -I../src/cuda -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -MD -MQ src/liblibvmaf_feature.a.p/feature_iqa_convolve.c.o -MF src/liblibvmaf_feature.a.p/feature_iqa_convolve.c.o.d -o src/liblibvmaf_feature.a.p/feature_iqa_convolve.c.o -c ../src/feature/iqa/convolve.c
[43/165] clang -Isrc/libvmaf.3.dylib.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -pedantic -DOC_NEW_STYLE_INCLUDES -MD -MQ src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o -MF src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o.d -o src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o -c src/vmaf_b_v0.6.3.json.c
FAILED: src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o 
clang -Isrc/libvmaf.3.dylib.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -pedantic -DOC_NEW_STYLE_INCLUDES -MD -MQ src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o -MF src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o.d -o src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o -c src/vmaf_b_v0.6.3.json.c
src/vmaf_b_v0.6.3.json.c:34077:1: error: unknown type name 'size_t'
size_t src_vmaf_b_v0_6_3_json_len = 408883;
^
1 error generated.
[44/165] clang -Isrc/liblibvmaf_feature.a.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -I../src/cuda -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -MD -MQ src/liblibvmaf_feature.a.p/feature_cambi.c.o -MF src/liblibvmaf_feature.a.p/feature_cambi.c.o.d -o src/liblibvmaf_feature.a.p/feature_cambi.c.o -c ../src/feature/cambi.c
[45/165] clang -Isrc/liblibvmaf_feature.a.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -I../src/cuda -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -MD -MQ src/liblibvmaf_feature.a.p/feature_integer_adm.c.o -MF src/liblibvmaf_feature.a.p/feature_integer_adm.c.o.d -o src/liblibvmaf_feature.a.p/feature_integer_adm.c.o -c ../src/feature/integer_adm.c
ninja: build stopped: subcommand failed.

Do not report this issue to Homebrew/brew or Homebrew/homebrew-core!

@tothxa
Copy link
Member

tothxa commented Feb 7, 2024

@klaus-halfmann @matthiakl
But that deprecation thing needs handling too. According to actions/runner-images#9255 macOS 11 runner images will be removed in Q2 2024.

I know we have problems publishing builds for later macOS versions, but I couldn't figure out which old bug report is most appropriate for this, nor the current state of some of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working building & packaging Building, packaging, continuous integration, appdata, cmake macos Compiling and packaging for Apple urgent Needs to be fixed before the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants