Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of errors when printing #297

Open
1 of 2 tasks
Matsemann opened this issue Dec 1, 2014 · 8 comments
Open
1 of 2 tasks

Lots of errors when printing #297

Matsemann opened this issue Dec 1, 2014 · 8 comments

Comments

@Matsemann
Copy link

Tried with this page: https://www.wikipendium.no/TI%C3%984146_Finance (on this revision https://www.wikipendium.no/TI%C3%984146_Finance/history/3052/ )

List of TODOs:

  • No header
  • Fix images on page breaks
  • No header on first page
  • But a header on every following page, this header overlaps with the text so not all text is visible on the print
  • Images on page breaks, could apply css-rule to images so they are not cut in half (page-break-inside: avoid)

First page:

firstpage

Two other pages:

otherpage

@stianjensen
Copy link
Member

We're aware of some issues with printing, but they seem to vary greatly between browsers.
Hiding navigation is a simple cross-browser fix, so I'll push an update for that.
But many of the other issues I can't reproduce in Google Chrome, what browser did you use?

@stianjensen
Copy link
Member

I tried out the page-break-inside property in Firefox, but it doesn't seem to have any effect.

I've created a pull request which resolves the issues with the header, and will have another go at image floating later.

@Matsemann
Copy link
Author

As for page-break-inside, there are some issues applying it directly to an image. You will need to wrap the image and apply it to the container. E.g. <div class"no-break"><img..></div>, or sometimes it works just by having the image inside something with display block. I had some issues with something similar this summer as well..

@cristeahub
Copy link
Member

I've updated the comment to include fixes that needs to be done.

The removal of the headers makes it seem that images does not break on pages, but I think a bit more testing of this would be good.

Update: As pointed out before, the images still break in firefox :/

@sigvef
Copy link
Collaborator

sigvef commented May 24, 2015

Has this been fixed by the recent updates to print styling?

@stianjensen
Copy link
Member

I would suppose there will be fewer issues now since we pack more content on each page, but we still haven't done anything in particular to ensure nice floating of images between page breaks.

@Matsemann
Copy link
Author

Removing display:block from img fixes them in Fx at least.
A second problem that interferes with printing is the negative margin on #article section

Other than that, it looks good.

@stianjensen
Copy link
Member

I'll look into to the block-display, and see if we can make that work.

And negative margins can be removed on print, so I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants