Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update process should check version and not allow reversion through update #765

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parsharma
Copy link
Contributor

Issue: #759

@parsharma parsharma changed the title Draft:Update process should check version and not allow reversion through update Update process should check version and not allow reversion through update Sep 23, 2024
@TomasHofman
Copy link
Contributor

Relevant wildfly-channel issue that I think we would need implemented there in order to complete this functionality:
wildfly-extras/wildfly-channel#292

@TomasHofman
Copy link
Contributor

A good next step could be to obtain a list of manifests used by the current installation. I think it should be possible to obtain maven GAVs (or URLs) of the current manifests. If there are any Maven based manifest found in the list, they should be matched against the list of new manifests (which the user want to upgrade to) used by the ChannelSession.

(That list of new manifests is currently simulated by the findManifestUpdates() method, hard-coded to only return org.jbosss.eap.channels:eap-8.0 manifest artifact, because we don't know how to obtain these data.)

@parsharma
Copy link
Contributor Author

Hello @TomasHofman,
I have updated the code where we are getting list of manifests from the current installation.

@TomasHofman
Copy link
Contributor

Now can we get the list of manifests currently used by the installation? Maybe from the InstallationMetadata class?

If we can have that, we can try to obtain an intersection from those two lists (manifests groupId:artifactId s that are present in both currently installed manifest and the newly available manifests used by the channelSession).

Once we have that intersection, we can try to compare the versions to see if they are upgrading or downgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants