Introduce two exceptions to distinquish between resolution failures #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfdenise
reviewed
May 23, 2023
| super(localizedMessage, cause, unresolvedArtifacts, attemptedRepositories); | ||
| } | ||
|
|
||
| public <E> ArtifactTransferException(String message, Set<ArtifactCoordinate> unresolvedArtifacts, Set<Repository> attemptedRepositories) { |
There was a problem hiding this comment.
Why do we need the E parameter, same for the other exception?
There was a problem hiding this comment.
We don't, sorry copy/paste from base exception.
Removed it now, I don't think we need it on the UnresolvedMavenArtifactException either
jmesnil
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
NoStreamFoundExceptionandArtifactTransferExceptionto theChannelSessionandVersionResolverAPI.NoStreamFoundExceptionshould be thrown if the channels don't provide a requested artifact, whileArtifactTransferExceptionwraps an underlying Maven transfer/resolution error.This is required to correctly support fallback version resolution when the artifact is not found in channel.