Escape properties variables

[ottuzzi-at-vegans]

Hi there,

we are trying to use the plugin to provision a fully configured wildfly for our environment but we have a problem while provisioning the datasource. We produce docker images at build time with wildfly and our ear packaged together and then we deploy the same image in TEST/UAT/PROD.
Our deploy system expects to read the datasource URL/credentials from environment variables so we tried to use the plugin with this configuration:

<resource>
    <address>xa-data-source=java:jboss/jdbc/${env.ENVIRONMENT}XADS</address>
    <properties>
        <xa-datasource-class>org.postgresql.xa.PGXADataSource</xa-datasource-class>
        <jndi-name>java:jboss/jdbc/${env.ENVIRONMENT}XADS</jndi-name>
        <enabled>true</enabled>
        <driver-name>postgresql-42.7.0.jar</driver-name>
    </properties>
    <resources>
        <resource>
            <address>
                xa-datasource-properties=DatabaseName
            </address>
            <properties>
                <value>applicationDb</value>
            </properties>
        </resource>
        <resource>
            <address>
                xa-datasource-properties=ServerName
            </address>
            <properties>
                <value>${env.DB_CONNECTION_URL}</value>
            </properties>
        </resource>
        <resource>
            <address>
                xa-datasource-properties=User
            </address>
            <properties>
                <value>${env.DB_USERNAME}</value>
            </properties>
        </resource>
        <resource>
            <address>
                xa-datasource-properties=Password
            </address>
            <properties>
                <value>${env.DB_PASSWORD}</value>
            </properties>
        </resource>
    </resources>

The produced settings.xml does not contain ${env.DB_CONNECTION_URL} as the ServerName attribute value but it is immediately replaced with the environment variable found at build time.
Is there any workaround to this issue?

Thanks in advance
Piero

[jamezp]

IIRC you escape it with another $ so you'd have $${env.DB_CONNECTION_URL}.

[ottuzzi-at-vegans]

Hi,

this is not working as expected.
If I set ENVIRONMENT=DEV as env variable and then I write the following configuration snippet:

<execution>
    <id>add-datasource</id>
    <phase>install</phase>
    <goals>
        <goal>add-resource</goal>
    </goals>
    <configuration>
        <address>subsystem=datasources</address>
        <resources>
            <resource>
                <address>xa-data-source=java:jboss/jdbc/$${env.ENVIRONMENT}XADS</address>
                <properties>
                    <xa-datasource-class>org.postgresql.xa.PGXADataSource</xa-datasource-class>
                    <jndi-name>java:jboss/jdbc/$${env.ENVIRONMENT}XADS</jndi-name>
                    <enabled>true</enabled>
                    <driver-name>postgresql-42.7.0.jar</driver-name>
                </properties>

the produced standalone.xml is

<subsystem xmlns="urn:jboss:domain:datasources:7.0">
    <datasources>
        <xa-datasource jndi-name="java:jboss/jdbc/$DEVXADS" pool-name="java:jboss/jdbc/$DEVXADS" enabled="true">
            <xa-datasource-property name="DatabaseName">
                myDB
            </xa-datasource-property>
            [...]
        </xa-datasource>
    </datasources>
</subsystem>

Please note the $ sign before DEV (so it is replacing the variable and prepending $).
but I would like a result like

<subsystem xmlns="urn:jboss:domain:datasources:7.0">
    <datasources>
        <datasource jndi-name="java:jboss/jdbc/${env.ENVIRONMENT}XADS" pool-name="${env.ENVIRONMENT}XADS" enabled="true" use-java-context="true" statistics-enabled="${wildfly.datasources.statistics-enabled:${wildfly.statistics-enabled:false}}">
            [...]
    </datasources>
</subsystem>

I tried to convince Maven to not replace but I did not find any working solution.

Piero

[jamezp]

I'll keep looking, but one workaround would be to define something like:

<properties>
    <property.prefix>$</property.prefix>
</properties>

Then in the plugin configuration set the value to something like ${property.prefix}{env.ENVIRONMENT}.

I'll keep looking because I could have sworn I've done this before, but I'm failing to remember what worked.

[ottuzzi-at-vegans]

Hi,

thanks again but also this solution is not working.
Here is the pom.xml

and this is the result:

We are using maven 3.9.x with JDK17 using the latest GA wildfly-maven-plugin (I trried also the 5.0.0-Alpha but the issue is still there).

[jamezp]

This worked for me:

<configuration>
    <commands>
        <command>/system-property=db.name:add(value=sa)</command>
        <command>/system-property=db.password:add(value=sa)</command>
    </commands>
    <address>subsystem=datasources,data-source=java:jboss/myDs</address>
    <resources>
        <resource>
            <properties>
                <jndi-name>java:jboss/myDs</jndi-name>
                <enabled>true</enabled>
                <connection-url>jdbc:h2:mem:test;DB_CLOSE_DELAY=-1</connection-url>
                <driver-class>org.h2.Driver</driver-class>
                <driver-name>h2</driver-name>
                <user-name>$${db.name}</user-name>
                <password>$${db.password}</password>
            </properties>
        </resource>
    </resources>
</configuration>

<datasource jndi-name="java:jboss/myDs" pool-name="java:jboss/myDs" enabled="true">
    <connection-url>jdbc:h2:mem:test;DB_CLOSE_DELAY=-1</connection-url>
    <driver-class>org.h2.Driver</driver-class>
    <driver>h2</driver>
    <security user-name="${db.name}" password="${db.password}"/>
</datasource>

What seemed to be an issue though is if one of the properties was resolvable by Maven, it would resolve it. If you execute mvn help:effective-pom and look at the configuration for the wildfly-maven-plugin does it show those values resolved?