Fix for WFMP-209, Can't use maven http transport with maven < 3.9 #343
Conversation
jfdenise
force-pushed
the
main
branch
2 times, most recently
from
ae3fde1
to
5761661
Compare
|
@jamezp , the remaining failure is un-related to this change. This build image tests failed in some previous runs. |
Yes, I've been thinking about disabling these tests for Windows as they seem flaky. I guess I should dig into why they are flaky first though :) |
tests/standalone-tests/pom.xml
Outdated
| @@ -61,17 +61,17 @@ | |||
| <dependency> | |||
| <groupId>org.apache.maven.resolver</groupId> | |||
| <artifactId>maven-resolver-api</artifactId> | |||
| <scope>test</scope> | |||
| <scope>provided</scope> | |||
There was a problem hiding this comment.
What's the reason for these being changed from test to provided? TBH it looks weird to me to have them at all.
There was a problem hiding this comment.
They are required for compilation, they were transitively included.
There was a problem hiding this comment.
There isn't anything that's a non-test that should need to be compiled. If test scope doesn't work it seems like something is wrong.
There was a problem hiding this comment.
@jamezp you were right, I fixed the pom.
Issue: https://issues.redhat.com/browse/WFMP-209
The maven-resolver dependencies are not needed by the plugin. We must rely on default Maven handling of the transport aspects.