Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail step when Wiremock ping fails #2

Closed
williamhaw opened this issue Mar 30, 2020 · 1 comment
Closed

Fail step when Wiremock ping fails #2

williamhaw opened this issue Mar 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@williamhaw
Copy link
Owner

williamhaw commented Mar 30, 2020 •
edited
Loading

Sometimes the ping fails. Example run: https://github.com/williamhaw/setup-wiremock-action/runs/545295691
From the error message:

##[error]connect ECONNREFUSED 127.0.0.1:8080

it seems that Wiremock was not started.

Need to investigate why Wiremock doesn't start, but as a first step, the step should fail so that the job can be retried.

Calling core.setFailed() doesn't seem to fail the step:

Exiting the Node process with status 1 doesn't seem to make it fail:
@williamhaw williamhaw added the bug Something isn't working label Mar 30, 2020
@williamhaw
Copy link
Owner Author

Fixed by removing continue-on-error: true in the workflow yaml file.

@slice-jayanthc slice-jayanthc mentioned this issue Nov 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@williamhaw