Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable removing type="text" on <input> elements #134

Closed
susheel61 opened this issue Mar 3, 2023 · 7 comments
Closed

Add option to disable removing type="text" on <input> elements #134

susheel61 opened this issue Mar 3, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@susheel61
Copy link

No description provided.

@susheel61
Copy link
Author

input type="text" is getting removed

@susheel61 susheel61 changed the title input type=text is getting removed input type="text" is getting removed Mar 3, 2023
@wilsonzlin
Copy link
Owner

This is intentional, see #95 (comment) for more details.

@susheel61
Copy link
Author

susheel61 commented Mar 6, 2023 •
edited
Loading

Is there a way to disable it because I already have css on input text type

@wilsonzlin
Copy link
Owner

I'll investigate adding an option to disable minification for input[type=text] specifically.

@wilsonzlin wilsonzlin reopened this Mar 6, 2023
@wilsonzlin wilsonzlin added the enhancement New feature or request label Mar 6, 2023
@wilsonzlin wilsonzlin changed the title input type="text" is getting removed Add option to disable removing type="text" on <input> elements Mar 6, 2023
@susheel61
Copy link
Author

Thanks I tried to contribute but didn't find any specific java code so was confused. Anyways thanks for taking this up.

@octoape
Copy link

octoape commented Mar 9, 2023

Yes, many css will use input[type=text], hopefully support will be provided.

@Nemo157 Nemo157 mentioned this issue Sep 16, 2023
Open
@wilsonzlin
Copy link
Owner

I've added an option keep_input_type_text_attr in version 0.15.0 to preserve type=text attributes on <input> elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@susheel61 @wilsonzlin @octoape