feat: workspace error handler #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Deploying with
|
| Latest commit: |
024d5dc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc65ac89.windmill.pages.dev |
| Branch Preview URL: | https://feat-workspace-error-handler.windmill.pages.dev |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
rubenfiszel
reviewed
Jul 6, 2023
backend/windmill-queue/src/jobs.rs
Outdated
Comment on lines
462
to
483
| if let Some(error_handler) = error_handler { | ||
| run_error_handler( | ||
| rsmq.clone(), | ||
| queued_job, | ||
| db, | ||
| result, | ||
| &error_handler.strip_prefix("script/").unwrap(), | ||
| false, | ||
| None, | ||
| ) | ||
| .await?; | ||
| } | ||
|
|
||
| if let Some(ref global_error_handler) = *GLOBAL_ERROR_HANDLER_PATH_IN_ADMINS_WORKSPACE { | ||
| run_error_handler( | ||
| rsmq.clone(), | ||
| queued_job, | ||
| db, | ||
| result, | ||
| global_error_handler, | ||
| true, | ||
| tag, | ||
| ) | ||
| .await?; |
There was a problem hiding this comment.
If you do this, failure of error handler will prevent global error handler to trigger :)
There was a problem hiding this comment.
You want to run both and return a new meta error if error that is merge or one of them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.