Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Exclude tags #18

Merged
merged 2 commits into from
Oct 8, 2015
Merged

Exclude tags #18

merged 2 commits into from
Oct 8, 2015

Conversation

BackSlasher
Copy link
Contributor

  1. Move filtering to a separate function (DRY)
  2. Allowing ignoring (excluding) groups that contain a nonempty value in a specific tag. Multiple tags can be specified.

@BackSlasher
Refactored group filtering to function
f88d840
@BackSlasher
Now supporting tag filtering
8b8ca5a 
Passing tags using `-t TAG` or `--exclude_tag TAG` will ignore AWS
security groups with nonempty value in this tag
@BackSlasher
Copy link
Contributor Author

ping

@winebarrel
Copy link
Collaborator

Thanks for PR 😃
I'm sorry merge is delayed

winebarrel pushed a commit that referenced this pull request Oct 8, 2015
Merge pull request #18 from BackSlasher/exclude-tags
973ecde 
Exclude tags
@winebarrel winebarrel merged commit 973ecde into codenize-tools:master Oct 8, 2015
@BackSlasher
Copy link
Contributor Author

Thank you for the merge. I was afraid you've gone away :)

@BackSlasher BackSlasher deleted the exclude-tags branch October 8, 2015 06:55
@BackSlasher
Copy link
Contributor Author

@winebarrel please ping me when it's included in a proper gem version
Thanks!

@winebarrel
Copy link
Collaborator

@BackSlasher I'm sorry release is delayed.
I'm going to release new gem today.

@BackSlasher
Copy link
Contributor Author

No rush :)

Nitzan Raz
http://backslasher.net

On Sun, Oct 18, 2015 at 8:38 AM, Genki Sugawara notifications@github.com
wrote:

@BackSlasher https://github.com/BackSlasher I'm sorry release is
delayed.
I'm going to release new gem today.

—
Reply to this email directly or view it on GitHub
#18 (comment).

@winebarrel
Copy link
Collaborator

@BackSlasher v0.2.9.beta2 has been released! Please try it out 😃

@BackSlasher
Copy link
Contributor Author

Thanks, will do!

Nitzan Raz
http://backslasher.net

On Sun, Oct 18, 2015 at 10:49 AM, Genki Sugawara notifications@github.com
wrote:

@BackSlasher https://github.com/BackSlasher v0.2.9.beta2
https://rubygems.org/gems/piculet/versions/0.2.9.beta2 has been
released! Please try it out [image: 😃]

—
Reply to this email directly or view it on GitHub
#18 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BackSlasher @winebarrel