From 950c4989343f1fa5ccd51438a834f7627f329fce Mon Sep 17 00:00:00 2001 From: Harsh Raghav Date: Wed, 9 Oct 2024 04:53:51 +0000 Subject: [PATCH] Pull request #27: changed phone to mobile Merge in SST/android-sdk from fix/deviceType to master Squashed commit of the following: commit 85395a378429e9c0082b82309299bac1f15e696c Author: harsh.raghav@wingify.com Date: Tue Oct 8 17:55:57 2024 +0530 changed phone to mobile --- .../src/main/java/com/vwo/mobile/constants/AppConstants.java | 2 +- .../vwo/mobile/segmentation/CustomSegmentEvaluateEnum.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/library/src/main/java/com/vwo/mobile/constants/AppConstants.java b/library/src/main/java/com/vwo/mobile/constants/AppConstants.java index 284e5eb..d29f476 100644 --- a/library/src/main/java/com/vwo/mobile/constants/AppConstants.java +++ b/library/src/main/java/com/vwo/mobile/constants/AppConstants.java @@ -47,7 +47,7 @@ public class AppConstants { public static final String USER_TYPE_NEW = "new"; public static final String USER_TYPE_RETURNING = "ret"; - public static final String DEVICE_TYPE_PHONE = "Phone"; + public static final String DEVICE_TYPE_MOBILE = "Mobile"; public static final String DEVICE_TYPE_TABLET = "Tablet"; //region Keys in Events diff --git a/library/src/main/java/com/vwo/mobile/segmentation/CustomSegmentEvaluateEnum.java b/library/src/main/java/com/vwo/mobile/segmentation/CustomSegmentEvaluateEnum.java index 5e723f8..83732ca 100644 --- a/library/src/main/java/com/vwo/mobile/segmentation/CustomSegmentEvaluateEnum.java +++ b/library/src/main/java/com/vwo/mobile/segmentation/CustomSegmentEvaluateEnum.java @@ -547,7 +547,7 @@ public boolean evaluate(VWO vwo, JSONArray data) { try { String type = data.getString(i); return isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_TABLET) || - !isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_PHONE); + !isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_MOBILE); } catch (Exception exception) { VWOLog.e(VWOLog.SEGMENTATION_LOGS, "Unable to parse device type", exception, false, false); @@ -570,7 +570,7 @@ public boolean evaluate(VWO vwo, JSONArray data) { try { String type = data.getString(i); return !isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_TABLET) || - isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_PHONE); + isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_MOBILE); } catch (Exception exception) { VWOLog.e(VWOLog.SEGMENTATION_LOGS, "Unable to parse device type", exception, false, false);