Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution loop detection sometimes false triggers #26

Open
llysdal opened this issue Jul 22, 2023 · 0 comments
Open

Execution loop detection sometimes false triggers #26

llysdal opened this issue Jul 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@llysdal
Copy link
Member

llysdal commented Jul 22, 2023

Can be replicated using apply_force.txt FPGA chip

Debugging shows that this happens:

nodeQueue = {1,3,2,5,} when we put down 1 as our loop detection node
nodeQueue = {1,3,4,5,} 4 iterations later

Loop detection now triggers, as we have reached node 1 again, and our nodeQueue is the same size as when we first saw 1.

The loop detection code should of course ensure that the node id's in the nodeQueue are identical to when we started loop detection.

@llysdal llysdal added the bug Something isn't working label Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant