Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for the injectRoute API #3762

Closed
1 task
tony-sull opened this issue Jun 28, 2022 · 1 comment
Closed
1 task

Add test coverage for the injectRoute API #3762

tony-sull opened this issue Jun 28, 2022 · 1 comment
Labels
- P1: chore Doesn't change code behavior (priority)

Comments

@tony-sull
Copy link
Contributor

What version of astro are you using?

1.0.0-beta.58

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Mac

Describe the Bug

injectRoute doesn't have any test coverage yet!

Coverage needed

  • astro dev
  • astro build for SSR builds
  • injecting basic pages, /_admin
  • injected API endpoints
  • injecting dynamic routes, /_admin/[userid]
  • injecting dynamic routes with rest params, /_admin/[...params]

Link to Minimal Reproducible Example

NA

Participation

  • I am willing to submit a pull request for this issue.
@tony-sull tony-sull added - P1: chore Doesn't change code behavior (priority) s2-medium labels Jun 28, 2022
@tony-sull tony-sull mentioned this issue Jun 28, 2022
Merged
@FredKSchott
Copy link
Member

We use the bug tracker for issues, and not chore/TODOs like this!

This was referenced Sep 28, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P1: chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FredKSchott @tony-sull