Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trailingSlash: "always" break on Vercel #7444

Closed
1 task
anasrar opened this issue Jun 22, 2023 · 1 comment · Fixed by #7447
Closed
1 task

trailingSlash: "always" break on Vercel #7444

anasrar opened this issue Jun 22, 2023 · 1 comment · Fixed by #7447
Assignees
@bluwy
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) pkg: vercel Related to Vercel adapter (scope)

Comments

@anasrar
Copy link

anasrar commented Jun 22, 2023

What version of astro are you using?

2.6.6

Are you using an SSR adapter? If so, which one?

@astrojs/vercel@3.5.0

What package manager are you using?

pnpm

What operating system are you using?

Linux

What browser are you using?

Chrome

Describe the Bug

when trailingSlash: "always" is presented in config, access / will continuously redirect to /. Resulting infinite redirect when deployed on Vercel.

What's the expected result?

See basics template on /.

Link to Minimal Reproducible Example

https://github.com/anasrar/astro-vercel-trailingslash

Participation

  • I am willing to submit a pull request for this issue.
@bluwy bluwy added - P4: important Violate documented behavior or significantly impacts performance (priority) pkg: vercel Related to Vercel adapter (scope) labels Jun 22, 2023
@bluwy bluwy self-assigned this Jun 22, 2023
@bluwy bluwy mentioned this issue Jun 22, 2023
Merged
@artt
Copy link

artt commented Dec 27, 2024

@bluwy seems like this is still an issue? What do you use for your setup now?
withastro/adapters#418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluwy bluwy

Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) pkg: vercel Related to Vercel adapter (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix vercel redirects with trailingSlash always withastro/astro
3 participants
@artt @bluwy @anasrar