Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an error message for non-string transition:name values #10205

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

martrapp
Copy link
Member

@martrapp martrapp commented Feb 22, 2024

Changes

Closes #10150

I think throwing an error is pretty brutal but at least it shows up during astro dev.
Is there a way to access a logger here?

I'm unsure whether we really need the check this way:
[ - ] IDE integrations and astro check warn correctly, (but we can't force everybody to use them).
[ + ] astro dev and astro build don't give any error message so far, see issue mentioned above.

Testing

Manual test

Docs

n.a. bugfix

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 7f10715

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 22, 2024
@ematipico
Copy link
Member

No, we don't have a logger in the runtime. I think it's fair to throw an error, a user might not see the log.

@matthewp matthewp merged commit 459f74b into main Feb 23, 2024
13 checks passed
@matthewp matthewp deleted the mt/warning branch February 23, 2024 14:00
@astrobot-houston astrobot-houston mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
3 participants