Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(node): Custom headers are not present in responses from standalone Node server in preview mode #10208

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

log101
Copy link
Contributor

@log101 log101 commented Feb 23, 2024

Changes

Fixes: #10161

Adds user specified headers at config file (server.headers) to node standalone server responses in preview mode.

Testing

Added a test to check if custom headers are present in preview mode.

Note: The headers are still present at 404 responses I'm not sure if this is an expected behaviour.

Docs

n/a. bug fix.

Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: 9170248

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Feb 23, 2024
@matthewp
Copy link
Contributor

A+ PR! Good description. Tests. Correct changesets. Well done!

@matthewp matthewp merged commit 8cd38f0 into withastro:main Feb 23, 2024
14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node adapter ignores server.headers under astro preview
2 participants