Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alias use with hydration scripts #3376

Merged
merged 3 commits into from
May 16, 2022
Merged

Support alias use with hydration scripts #3376

merged 3 commits into from
May 16, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

Test added

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022

🦋 Changeset detected

Latest commit: b6ea17a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 16, 2022
...script,
props: { ...script.props, 'astro-script': result._metadata.pathname + '/script-' + i },
});
return renderElement('script', script);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is not related to this change, just noticed that we were still adding these special attributes. They were used by the legacy build system but are not needed any more.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice—looks great!

@matthewp matthewp merged commit b123015 into main May 16, 2022
@matthewp matthewp deleted the fix-alias branch May 16, 2022 15:37
@github-actions github-actions bot mentioned this pull request May 16, 2022
florian-s-code pushed a commit to florian-s-code/astro that referenced this pull request May 16, 2022
* Support alias use with hydration scripts

* Adds a changeset

* Updated lockfile
natemoo-re pushed a commit that referenced this pull request May 17, 2022
@florian-s-code
Copy link
Contributor

I saw this PR got a revalidate flag so I thought I might as well comment here.
Please ignore if irrelevant but I was testing aliases on my side, more specifically on build. So I tried to write a test that would build the fixture created for this PR, but the build fails, the alias doesn't seem to work.

The start of the implementation that I couldn't finish: added a describe block but the whole it block inside is not yet modified:
florian-s-code@cbcbf98

matthewp pushed a commit that referenced this pull request May 18, 2022
* test: remove it.only

* test: skip failure until #3376 is revisited
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Support alias use with hydration scripts

* Adds a changeset

* Updated lockfile
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* test: remove it.only

* test: skip failure until withastro#3376 is revisited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Svelte components crash dev if imported with a shortened path
3 participants