Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly await on children before hydrating in Safari #3891

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • In Safari connectedCallback is called before an element has children, so we need to wait for the children to occur before beginning the hydration process.
  • A await-children attribute is added when we need to do this, but is a boolean attribute. Since we are using !this.getAttribute('await-children') this is always going to be a falsey condition. Using hasAttribute instead since that is the intended logic.
  • Fixes 🐛 BUG: Safari production build losing reactivity on refresh #3878

Testing

  • No test added, Safari only condition and we don't have E2E tests for Safari at the moment.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2022

🦋 Changeset detected

Latest commit: 3191c7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 11, 2022
@matthewp matthewp merged commit 9cf7e40 into main Jul 11, 2022
@matthewp matthewp deleted the safari-await-children branch July 11, 2022 18:10
@astrobot-houston astrobot-houston mentioned this pull request Jul 11, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Safari production build losing reactivity on refresh
3 participants