Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Solid libraries config handling #5208

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Improve Solid libraries config handling #5208

merged 2 commits into from
Oct 28, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 27, 2022

Changes

Partial fix to #4652

Similar to #5203 but for the Solid integration.

I did tried looking into using vite-plugin-solid directly, but it indeed looks like it's JSX handling is interfering with Astro's, so keep our Solid implementation as is for now.

Testing

All existing tests should pass.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022

🦋 Changeset detected

Latest commit: b5b2eb1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) labels Oct 27, 2022
@bluwy bluwy merged commit c98c5aa into main Oct 28, 2022
@bluwy bluwy deleted the solid-lib-improve branch October 28, 2022 15:30
@astrobot-houston astrobot-houston mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: solid Related to Solid (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants