Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated according to new configuration #5478

Merged
merged 18 commits into from
Jan 26, 2023
Merged

Conversation

nemo0
Copy link
Contributor

@nemo0 nemo0 commented Nov 25, 2022

Astro imports the defineConfig function from astro/config. The integrations key needs to be passed into the defineConfig function, but it is not shown in the README. Updated the README according to the CLI example.

Changes

  • The astro.config.mjs example shown in the README is changed

Testing

Docs

@nemo0 nemo0 requested a review from a team as a code owner November 25, 2022 18:08
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022

🦋 Changeset detected

Latest commit: 8f75400

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) labels Nov 25, 2022
@matthewp
Copy link
Contributor

matthewp commented Dec 8, 2022

@nemo0 can you update the other readmes?

@nemo0
Copy link
Contributor Author

nemo0 commented Dec 8, 2022

Hey @matthewp . Sure. I would love to update the readmes.

@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) labels Jan 26, 2023
nemo0 and others added 4 commits January 26, 2023 08:20
Astro imports the `defineConfig` function from `astro/config`. The `integrations` key needs to be passed into the `defineConfig` function, but it is not shown in the README. Updated the README according to the CLI example.
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @natemoo-re!

@MoustaphaDev
Copy link
Member

MoustaphaDev commented Jan 26, 2023

Found the last one in the svelte integration readme line 102

@natemoo-re natemoo-re merged commit 1c7eef3 into withastro:main Jan 26, 2023
This was referenced Jan 26, 2023
@sarah11918
Copy link
Member

Just a heads up that because this PR was opened so long ago, one of its original pages was outdated. Since it was accepted into the main branch for its minor changes to the config example, it brought back with it the "old" page.

And, this merging was done after I had looked at the changes and approved. I'm not sure how we avoid this from happening again, but maybe when addressing a super-old PR we make sure the author first updates their branch?

cc @natemoo-re

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants