Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more unnecessary polyfills from webapi for Node 16 #5814

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Jan 10, 2023

Changes

Follow-up to #5782 removing more unnecessary polyfills from Webapi. In the future, Node 18 will allow us to remove some other ones (structuredClone, FormData etc), but that'll be for later

Alternatively we move Astro to deno and remove this entire package alltogether

Testing

Tests still pass! I also removed the tests in webapi testing previously polyfilled things, since testing that Node actually has the stuff it says it does seemed a bit redundant

Docs

N/A

@Princesseuh Princesseuh requested a review from a team as a code owner January 10, 2023 11:40
@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: 3247cb1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Princesseuh Princesseuh self-assigned this Jan 10, 2023
@sarah11918 sarah11918 removed the request for review from a team January 10, 2023 12:44
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to polyfil-ter out these Node 14 deps! Don't have much experience with the webapi package internals, though these deletions seem correct to me

@Princesseuh Princesseuh merged commit c55fbcb into main Jan 10, 2023
@Princesseuh Princesseuh deleted the fix/remove-unnecessary-polyfills branch January 10, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants