Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined remarkPluginFrontmatter after calling render method #5927

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

izmttk
Copy link
Contributor

@izmttk izmttk commented Jan 21, 2023

Changes

Fixes #5859 where frontmatter is not exported but is used in

remarkPluginFrontmatter: mod.frontmatter,

Testing

no tests

Docs

nothing changed

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2023

🦋 Changeset detected

Latest commit: 98f67f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 21, 2023
andersk added a commit to andersk/astro that referenced this pull request Jan 25, 2023
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset but looks like a plugreat fix! You can add one by running pnpm run changeset in the project root. I'd make this one a patch fix.

@izmttk
Copy link
Contributor Author

izmttk commented Jan 26, 2023

Hi, changeset has been added. @bholmesdev

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@natemoo-re natemoo-re merged commit 322e059 into withastro:main Jan 26, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jan 26, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remarkPluginFrontmatter is undefined after render
4 participants