Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: astro check does not support TSC project references #920

Open
codethief opened this issue Jul 26, 2024 · 2 comments · Fixed by volarjs/volar.js#232
Open

🐛 BUG: astro check does not support TSC project references #920

codethief opened this issue Jul 26, 2024 · 2 comments · Fixed by volarjs/volar.js#232
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) ecosystem: upstream Issue is caused by a bug / missing feature upstream feat: check Issue in `astro-check` (scope)

Comments

@codethief
Copy link

codethief commented Jul 26, 2024 •
edited
Loading

Describe the Bug

This is a follow-up to my message here.

Passing a "solution-style" tsconfig.json to astro check, which references other projects (tsconfigs), will make the type checker silently accept type errors associated with types imported from those other projects.

The issue might be related to #649 since project references rely on emitting type declarations.

Steps to Reproduce

(This is a placeholder ticket for now; I will update it soon with example code to reproduce the issue.)

See https://github.com/codethief/tsconfig-playground/tree/fe78e51d4f4c62f801f281efd1ffff48ecdb32ea/2024-07-27-astro-with-project-references
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jul 26, 2024
@codethief codethief mentioned this issue Jul 26, 2024
Closed
1 task
@Princesseuh Princesseuh added needs repro Issue needs a reproduction and removed needs triage Issue needs to be triaged labels Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello @codethief. Please provide a minimal reproduction using a GitHub repository or at least sharing the file where the issue happen. Issues marked with needs repro will be closed if they have no activity within 3 days.

@codethief
Copy link
Author

codethief commented Jul 28, 2024 •
edited
Loading

@Princesseuh I added a minimal reproduction, see above.

@Princesseuh Princesseuh removed the needs repro Issue needs a reproduction label Jul 28, 2024
@Princesseuh Princesseuh added ecosystem: upstream Issue is caused by a bug / missing feature upstream feat: check Issue in `astro-check` (scope) - P3: minor bug An edge case that only affects very specific usage (priority) labels Aug 7, 2024
This was referenced Aug 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) ecosystem: upstream Issue is caused by a bug / missing feature upstream feat: check Issue in `astro-check` (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(kit): add support for checking project references files volarjs/volar.js
2 participants
@codethief @Princesseuh