Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox core should not read --configuration name from argv directly #338

Closed
MoOx opened this issue Oct 13, 2017 · 6 comments
Closed

Detox core should not read --configuration name from argv directly #338

MoOx opened this issue Oct 13, 2017 · 6 comments

Comments

@MoOx
Copy link
Contributor

MoOx commented Oct 13, 2017

I am using Jest just followed Jest guide.
The problem is: jest cli validate the argv arguments.
So you cannot just throw --configuration here.
The thing is: detox rely on argv to read this option so we cannot configure this via node API.
Are you open to a change to make configuration name an option for the node API too? Btw, argv thing should be on CLI, no in the core.

@rotemmiz
Copy link
Member

#335

@MoOx
Copy link
Contributor Author

MoOx commented Oct 13, 2017

This might help indeed, but I guess I will leave this issue open as it can happen for other runner until those are implemented. Will rename issue accordingly.

@MoOx MoOx changed the title Unable to use --configuration with Jest Detox core should not read --configuration name from argv directly Oct 13, 2017
@Kureev
Copy link
Contributor

Kureev commented Oct 13, 2017

Hi @MoOx! You can already check implementation in #335 😉

@MoOx
Copy link
Contributor Author

MoOx commented Oct 13, 2017

Yeah I saw this once, nice job :)

@Kureev
Copy link
Contributor

Kureev commented Oct 19, 2017

detox@5.9.0 has been released with #335 in it. Should be solved now, right? Can you please verify that the issue is gone now and if so, close the issue?

@rotemmiz
Copy link
Member

Closing this issue, Detox core now reads both argv and env vars (to support Jest)

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants