Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native 76 compatibility #4647

Closed
6 of 7 tasks
d4vidi opened this issue Nov 27, 2024 · 8 comments · Fixed by #4652
Closed
6 of 7 tasks

React Native 76 compatibility #4647

d4vidi opened this issue Nov 27, 2024 · 8 comments · Fixed by #4652

Comments

@d4vidi
Copy link
Collaborator

d4vidi commented Nov 27, 2024

Describe your idea

Tasks

Preview Give feedback
  1. status: accepted type: enhancement ⚡️
    gosha212
@Acex187x
Copy link

Acex187x commented Dec 5, 2024

Does Detox have any support of RN 76 for now? Just tried to run some e2e after update to 76 and it seems like test just hangs without any ability to control the app. Is it okay? Some estimate of when it will be resolved are much appreciated, thanks!

@gosha212
Copy link
Contributor

gosha212 commented Dec 9, 2024

@Acex187x Hi, the version is not release yet. Any way, we will support currently 76 without the new arch. You will need to opt-out in order to make it work. The new arch implementation is in progress #4175

@Omnicpie
Copy link

Omnicpie commented Dec 9, 2024

@gosha212 If that's the case, is there any timeframe by which #4175 will be complete? As far as I (and a brand new React Native project) would be concerned, there is no compatibility with 0.76 until the new arch is supported.

@gosha212
Copy link
Contributor

gosha212 commented Dec 9, 2024

@Omnicpie We can't estimate for sure because there are lots of unknown both in Android and iOS. I would estimate it in a few weeks - month. Currently you can opt out while waiting for the fix.

@Omnicpie
Copy link

Omnicpie commented Dec 9, 2024

@gosha212 some packages dropped support for the old architecture when bringing support for the new architecture (taking react-native-mmkv as my example here) so I'm not sure i entirely agree that simply opting-out is the solution, it would make a difference in package versioning as a whole, and could quite easily bring about other issues.

For us, it means that we cannot move forward with the upgrade for 75 -> 76 until support is added.

@tmitchel2
Copy link

Give them a break @Omnicpie, it's compatible with 76 if you just turn the new architecture off. If you're using a package that doesn't support the old architecture during this transition period then thats on you and your bad planning, not the detox devs. But i presume even for the example you have given you could downgrade to v2? Have you tried it?

Don't get me wrong, Im desperate myself for this to be working also but there are so many new arch bugs all over place on real devices and you just have to nudge it forwards as and when libs and core projects allow it.

@Omnicpie
Copy link

Omnicpie commented Dec 9, 2024

I'm not trying to be rude, so I'm sorry if that's how its coming across, I'm just trying to explain why the new arch should be a priority and some of my reasonings behind that.

Ofc it'll take as long as it needs to, I'm just very eager for it to move forward.

@noomorph
Copy link
Collaborator

noomorph commented Dec 9, 2024

It is challenging to migrate to the new RN versions and new arch at once — there are nontrivial fixes and changes to be made, and AFAIK @gosha212 is working on this matter right as we speak.

Very obscure logs, limited tooling to infer what some of those Looper messages mean - all that does not contribute to high velocity so his estimate is on realistic, if not on the optimistic side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants