From 052b14c42d21c9b9e26e0760ec1c421f8894fceb Mon Sep 17 00:00:00 2001 From: Matt McKenna Date: Mon, 26 Feb 2018 20:20:57 -0800 Subject: [PATCH 1/2] Update Example .travis.yml in CI Guide Installing applesimutils seems to be required to have builds pass in Travis. --- docs/Guide.RunningOnCI.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/Guide.RunningOnCI.md b/docs/Guide.RunningOnCI.md index ad013e0937..2e8245b809 100644 --- a/docs/Guide.RunningOnCI.md +++ b/docs/Guide.RunningOnCI.md @@ -68,6 +68,8 @@ env: - NODE_VERSION=stable install: +- brew tap wix/brew +- brew install --HEAD applesimutils - curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.2/install.sh | bash - export NVM_DIR="$HOME/.nvm" && [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" - nvm install $NODE_VERSION From 54a0efc318180b5c226352e8031f9a63609f7fb5 Mon Sep 17 00:00:00 2001 From: Matt McKenna Date: Wed, 28 Feb 2018 08:37:35 -0800 Subject: [PATCH 2/2] Update docs to remove --HEAD from brew command when installing applesimutils --- detox/src/devices/AppleSimUtils.js | 2 +- detox/src/devices/AppleSimUtils.test.js | 2 +- docs/Guide.RunningOnCI.md | 4 ++-- docs/Introduction.GettingStarted.md | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/detox/src/devices/AppleSimUtils.js b/detox/src/devices/AppleSimUtils.js index 0f1ec61c2d..0d05da7bec 100644 --- a/detox/src/devices/AppleSimUtils.js +++ b/detox/src/devices/AppleSimUtils.js @@ -187,7 +187,7 @@ class AppleSimUtils { } catch (ex) { throw new Error(`Could not parse response from applesimutils, please update applesimutils and try again. - 'brew uninstall applesimutils && brew tap wix/brew && brew install --HEAD applesimutils'`); + 'brew uninstall applesimutils && brew tap wix/brew && brew install applesimutils'`); } return parsed; } diff --git a/detox/src/devices/AppleSimUtils.test.js b/detox/src/devices/AppleSimUtils.test.js index fcd6a85049..6af5efcbea 100644 --- a/detox/src/devices/AppleSimUtils.test.js +++ b/detox/src/devices/AppleSimUtils.test.js @@ -122,7 +122,7 @@ describe('AppleSimUtils', () => { fail('should throw'); } catch (e) { expect(e.message).toMatch(`Could not parse response from applesimutils, please update applesimutils and try again. - 'brew uninstall applesimutils && brew tap wix/brew && brew install --HEAD applesimutils'`); + 'brew uninstall applesimutils && brew tap wix/brew && brew install applesimutils'`); } }); }); diff --git a/docs/Guide.RunningOnCI.md b/docs/Guide.RunningOnCI.md index 2e8245b809..126ab23074 100644 --- a/docs/Guide.RunningOnCI.md +++ b/docs/Guide.RunningOnCI.md @@ -69,7 +69,7 @@ env: install: - brew tap wix/brew -- brew install --HEAD applesimutils +- brew install applesimutils - curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.2/install.sh | bash - export NVM_DIR="$HOME/.nvm" && [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" - nvm install $NODE_VERSION @@ -136,7 +136,7 @@ workflows: #!/bin/bash brew tap wix/brew - brew install applesimutils --HEAD + brew install applesimutils title: Install Detox Utils - script: inputs: diff --git a/docs/Introduction.GettingStarted.md b/docs/Introduction.GettingStarted.md index 0bcb70967e..73704b82ec 100644 --- a/docs/Introduction.GettingStarted.md +++ b/docs/Introduction.GettingStarted.md @@ -46,7 +46,7 @@ A collection of utils for Apple simulators, Detox uses it communicate with the s ```sh brew tap wix/brew -brew install --HEAD applesimutils +brew install applesimutils ``` > TIP: Verify it works by typing in terminal `applesimutils` to output the tool help screen