From c69db4781ea12f1f40a8824f9a0930459be76f86 Mon Sep 17 00:00:00 2001 From: Kristofer Rye Date: Thu, 23 Aug 2018 07:16:38 -0500 Subject: [PATCH] build_framework.ios.sh: echo/exit from current shell The `()` syntax spawns a subshell and executes the commands. Hence, the "successful" `exit 0` is trapped and is effectively a no-op. This change instead moves the execution of the `echo` statement to the parent shell which causes the `exit 0` to actually kill the process where it is. --- detox/scripts/build_framework.ios.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/detox/scripts/build_framework.ios.sh b/detox/scripts/build_framework.ios.sh index 676f149fd0..c5156b8181 100755 --- a/detox/scripts/build_framework.ios.sh +++ b/detox/scripts/build_framework.ios.sh @@ -1,7 +1,7 @@ #!/bin/bash -e -x # Ensure Xcode is installed or print a warning message and return. -xcodebuild -version &>/dev/null || (echo "WARNING: Xcode is not installed on this machine. Skipping iOS framework build phase" && exit 0) +xcodebuild -version &>/dev/null || { echo "WARNING: Xcode is not installed on this machine. Skipping iOS framework build phase"; exit 0; } detoxRootPath="$(dirname $(dirname ${0}))" detoxVersion=`node -p "require('${detoxRootPath}/package.json').version"`