Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark mature coinbase deposits as immature following tip rollback #1487

Open
jp1ac4 opened this issue Nov 27, 2024 · 0 comments
Open

Mark mature coinbase deposits as immature following tip rollback #1487

jp1ac4 opened this issue Nov 27, 2024 · 0 comments

Comments

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Nov 27, 2024

This relates to the following TODO:

// TODO: mark coinbase deposits that were mature and became immature as such.

Now that we save transactions in the DB, we could check if a coin is from a coinbase deposit and should be marked as immature following a tip rollback. For this, I think it would be required to add an is_coinbase column to the transactions table.

The effect of this issue is that an immature coin might not be marked as such following a reorg and could therefore be included in a draft spend, even though it would be unspendable until mature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant