revive Clang 8 support (#722)

wjakob · Sep 18, 2024 · 14878e4 · 14878e4
1 parent 34dfd5f
commit 14878e4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -101,12 +101,9 @@ jobs:
           - cc: gcc-9
             cxx: g++-9
             apt: gcc-9
-          #- cc: clang-7
-          #  cxx: clang++-7
-          #  apt: clang-7
-          #- cc: clang-8
-          #  cxx: clang++-8
-          #  apt: clang-8
+          - cc: clang-8
+            cxx: clang++-8
+            apt: clang-8
           - cc: clang-9
             cxx: clang++-9
             apt: clang-9

diff --git a/docs/index.rst b/docs/index.rst
@@ -57,7 +57,7 @@ nanobinds depends on
 - **Python 3.8+** or **PyPy 7.3.10+** (the *3.8* and *3.9* PyPy flavors are
   supported, though there are :ref:`some limitations <pypy_issues>`).
 - **CMake 3.15+**.
-- **A C++17 compiler**: Clang 7+, GCC 8+, MSVC2019+, and the CUDA NVCC compiler
+- **A C++17 compiler**: Clang 8+, GCC 8+, MSVC2019+, and the CUDA NVCC compiler
   are officially supported. Others (MinGW, Cygwin, Intel, ..) may work as well
   but will not receive support.
 

diff --git a/include/nanobind/nb_tuple.h b/include/nanobind/nb_tuple.h
@@ -32,8 +32,8 @@ template <typename T, typename... Ts> struct tuple<T, Ts...> : tuple<Ts...> {
 
     tuple() = default;
     tuple(const tuple &) = default;
-    tuple(tuple &&) noexcept = default;
-    tuple& operator=(tuple &&) noexcept = default;
+    tuple(tuple &&) = default;
+    tuple& operator=(tuple &&) = default;
     tuple& operator=(const tuple &) = default;
 
     template <typename A, typename... As>