From 14878e41dcafa3be9bceb244044889c96005e6cc Mon Sep 17 00:00:00 2001 From: Wenzel Jakob Date: Wed, 18 Sep 2024 11:11:29 +0900 Subject: [PATCH] revive Clang 8 support (#722) --- .github/workflows/ci.yml | 9 +++------ docs/index.rst | 2 +- include/nanobind/nb_tuple.h | 4 ++-- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e86ac0e0..4fa0c445 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -101,12 +101,9 @@ jobs: - cc: gcc-9 cxx: g++-9 apt: gcc-9 - #- cc: clang-7 - # cxx: clang++-7 - # apt: clang-7 - #- cc: clang-8 - # cxx: clang++-8 - # apt: clang-8 + - cc: clang-8 + cxx: clang++-8 + apt: clang-8 - cc: clang-9 cxx: clang++-9 apt: clang-9 diff --git a/docs/index.rst b/docs/index.rst index fdc7048d..e9b53e01 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -57,7 +57,7 @@ nanobinds depends on - **Python 3.8+** or **PyPy 7.3.10+** (the *3.8* and *3.9* PyPy flavors are supported, though there are :ref:`some limitations `). - **CMake 3.15+**. -- **A C++17 compiler**: Clang 7+, GCC 8+, MSVC2019+, and the CUDA NVCC compiler +- **A C++17 compiler**: Clang 8+, GCC 8+, MSVC2019+, and the CUDA NVCC compiler are officially supported. Others (MinGW, Cygwin, Intel, ..) may work as well but will not receive support. diff --git a/include/nanobind/nb_tuple.h b/include/nanobind/nb_tuple.h index a04b466d..ab2c2920 100644 --- a/include/nanobind/nb_tuple.h +++ b/include/nanobind/nb_tuple.h @@ -32,8 +32,8 @@ template struct tuple : tuple { tuple() = default; tuple(const tuple &) = default; - tuple(tuple &&) noexcept = default; - tuple& operator=(tuple &&) noexcept = default; + tuple(tuple &&) = default; + tuple& operator=(tuple &&) = default; tuple& operator=(const tuple &) = default; template