Support Eigen::Block
s?
#218
adriendelsalle
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi!
First, thanks for this project :)
Description
It looks like the current implementation doesn't support the dense block API of
Eigen
.It would be awesome to handle this!
Tests
Adding the following tests:
test_eigen.cpp
test_eigen.py
leads a
TypeError
:Discussion
As far as I understand there are
type_caster
s for bothEigen::Map<T>
nanobind/include/nanobind/eigen/dense.h
Lines 175 to 177 in 5e6b210
and
Eigen::Ref<T>
nanobind/include/nanobind/eigen/dense.h
Lines 236 to 238 in 5e6b210
not covering the
Eigen::Block<T>
one.Naively
Eigen::Map<T>
could/should coverEigen::Block<T>
since both are derived fromEigen::MapBase<T>
? I can propose a PR on that!There is also this other discussion and associated PR on
Eigen
topic, but it looks like the scope is much larger.Let me know!
Beta Was this translation helpful? Give feedback.
All reactions