Fix py_stub_test dependency in out-of-source builds #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the dependency between py_stub stubgen invocation and `py_stub_test.py` source file when building out of source. Previously, the dependency would be on the original file in the source directory rather than the one copied to build directory, which could lead to stubgen being invoked prior to it being copied and therefore failing to import it.
|
Good catch, thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the dependency between py_stub stubgen invocation and
py_stub_test.pysource file when building out of source. Previously, the dependency would be on the original file in the source directory rather than the one copied to build directory, which could lead to stubgen being invoked prior to it being copied and therefore failing to import it.