-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Deleting photos from CameraRoll reports as success but they are still there #479
Comments
I'm preparing a PR from my own repo (https://github.com/lll000111/react-native-fetch-blob/tree/0.10.9) that addresses such issues. There were quite a few unused return values, some low-level OS methods don't throw an error when something didn't work but they return Is this Android or iOS? On Android I may have caught this problem with this new check of the result: https://github.com/lll000111/react-native-fetch-blob/blob/0.10.9/android/src/main/java/com/RNFetchBlob/RNFetchBlobFS.java#L459 |
Was for iOS but actually its not so much this libraries responsibility , at least on iOS. |
Hmm, according to https://github.com/wkh237/react-native-fetch-blob/blob/master/ios/RNFetchBlob/RNFetchBlob.m#L265 you should at least get an error from RNFB on iOS, since it does an explicit |
Nope, no errors. Hence painful false positives |
The RN patch you link to won't have an effect though if you use RNFB to remove files AFAICS. |
Hence I said i don't think its this library's responsibility. |
Well, you left the ticket open so I assumed it is... open. |
that came up in discussion with you. |
In any case, you did use RNFB to delete files, and whether or not it should have worked, if not you should at least have received an error and not a success for a deletion that did not happen. So this may still be a RNFB issue even if you switch to an RN method for deletion and won't need a solution any more, I think. |
yes, in any case RNFB needs to throw an error |
Then the issue should be left open? You can unsubscribe if you don't need the followup discussion. I care because I've been working on the error reporting of this package just those past days... |
Okay, I think this is incorrect, will see if it's possible to handle it. Otherwise, it should throw an error. |
As a task item / TODO: https://github.com/wkh237/react-native-fetch-blob/blob/master/ios/RNFetchBlob/RNFetchBlob.m#L265 I think There also is this strange report about something that looks like an iOS issue: https://stackoverflow.com/a/37055832/544779 Also: https://stackoverflow.com/a/5683277/544779 |
I added a small patch to the |
I'm deleting files from the camera roll, they have paths like:
"assets-library://asset/asset.JPG?id=6A0D5C5D-5839-49B5-878A-52AC130B2C9C&ext=JPG"
and I am doing an array of them, so code is like:
And the success case goes off but these photos are still in the camera roll.
Versions:
"react-native": "0.45.1",
"react-native-fetch-blob": "^0.10.8",
I was wondering if this could be something related to missing a permission in Info.plist, but when that happens, apps usually crash and in this case the app does not crash.
The text was updated successfully, but these errors were encountered: