Skip to content

Commit

Permalink
Use rev(.packages())
Browse files Browse the repository at this point in the history
Load the packages in the original order,
not the reverse of the original order.
  • Loading branch information
wlandau-lilly committed Oct 30, 2017
1 parent 3385825 commit 8a3558a
Show file tree
Hide file tree
Showing 16 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion R/config.R
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ config <- function(
},
cache = drake::get_cache(),
parallelism = drake::default_parallelism(),
jobs = 1, packages = (.packages()), prework = character(0),
jobs = 1, packages = rev(.packages()), prework = character(0),
prepend = character(0), command = drake::default_Makefile_command(),
args = drake::default_system2_args(
jobs = jobs,
Expand Down
2 changes: 1 addition & 1 deletion R/dataframes_graph.R
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ dataframes_graph <- function(
force(code)
},
cache = drake::get_cache(), jobs = 1,
parallelism = drake::default_parallelism(), packages = (.packages()),
parallelism = drake::default_parallelism(), packages = rev(.packages()),
prework = character(0), build_times = TRUE, digits = 3,
targets_only = FALSE,
split_columns = FALSE, font_size = 20, config = NULL,
Expand Down
4 changes: 2 additions & 2 deletions R/make.R
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
#' \code{make(..., parallelism = "Makefile", jobs = 2, args = "--jobs=4")}
#'
#' @param packages character vector packages to load, in the order
#' they should be loaded. Defaults to \code{(.packages())}, so you
#' they should be loaded. Defaults to \code{rev(.packages())}, so you
#' should not usually need to set this manually. Just call
#' \code{\link{library}()} to load your packages before \code{make()}.
#' However, sometimes packages need to be strictly forced to load
Expand Down Expand Up @@ -198,7 +198,7 @@ make <- function(
cache = drake::get_cache(),
parallelism = drake::default_parallelism(),
jobs = 1,
packages = (.packages()),
packages = rev(.packages()),
prework = character(0),
prepend = character(0),
command = drake::default_Makefile_command(),
Expand Down
4 changes: 2 additions & 2 deletions R/outdated.R
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ outdated <- function(
cache = drake::get_cache(),
parallelism = drake::default_parallelism(),
jobs = 1,
packages = (.packages()),
packages = rev(.packages()),
prework = character(0),
config = NULL
){
Expand Down Expand Up @@ -151,7 +151,7 @@ missed <- function(
},
jobs = 1,
parallelism = drake::default_parallelism(),
packages = (.packages()),
packages = rev(.packages()),
prework = character(0),
config = NULL
){
Expand Down
2 changes: 1 addition & 1 deletion R/parallel_ui.R
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ max_useful_jobs <- function(
},
cache = drake::get_cache(),
jobs = 1, parallelism = drake::default_parallelism(),
packages = (.packages()), prework = character(0), config = NULL,
packages = rev(.packages()), prework = character(0), config = NULL,
imports = c("files", "all", "none")
){
force(envir)
Expand Down
2 changes: 1 addition & 1 deletion R/plotgraph.R
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ plot_graph <- function(
},
cache = drake::get_cache(),
jobs = 1, parallelism = drake::default_parallelism(),
packages = (.packages()), prework = character(0),
packages = rev(.packages()), prework = character(0),
config = NULL,
file = character(0), selfcontained = FALSE,
build_times = TRUE, digits = 3, targets_only = FALSE,
Expand Down
4 changes: 2 additions & 2 deletions R/predict_runtime.R
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ predict_runtime <- function(
parallelism = drake::default_parallelism(),
jobs = 1,
future_jobs = jobs,
packages = (.packages()),
packages = rev(.packages()),
prework = character(0),
config = NULL,
digits = 3,
Expand Down Expand Up @@ -231,7 +231,7 @@ rate_limiting_times <- function(
parallelism = drake::default_parallelism(),
jobs = 1,
future_jobs = jobs,
packages = (.packages()),
packages = rev(.packages()),
prework = character(0),
config = NULL,
digits = 3,
Expand Down
2 changes: 1 addition & 1 deletion man/config.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/dataframes_graph.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/make.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/max_useful_jobs.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/missed.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/outdated.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/plot_graph.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/predict_runtime.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/rate_limiting_times.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8a3558a

Please sign in to comment.