Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitHub Action can now be used on ubuntu-18.04 runner #606

Merged
merged 2 commits into from
May 10, 2022

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Apr 30, 2022

Always install nox with python3.10 in order to allow using the action with an ubuntu-18.04 runner.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@mayeut mayeut force-pushed the fix-action-ubuntu18.04 branch 3 times, most recently from 16c69fb to 0c4540d Compare May 5, 2022 18:42
@FollowTheProcess FollowTheProcess self-requested a review May 7, 2022 07:36
@FollowTheProcess
Copy link
Collaborator

FollowTheProcess commented May 7, 2022

It might be a good idea (given the number of jobs that will be run here) to put a condition in the CI workflow to only run the actions tests if action.yml has changed?

Just so every PR isn't clobbered with a load of actions tests if they've not changed it

Something like this: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths

@mayeut
Copy link
Contributor Author

mayeut commented May 7, 2022

It might be a good idea (given the number of jobs that will be run here) to put a condition in the CI workflow to only run the actions tests if action.yml has changed?

That makes sense. I'd say only run on push to main or when there are changes in the action.

I can either create a new workflow file to use built-in filtering as you mentioned or introduce a new workflow dependency https://github.com/dorny/paths-filter to keep only one workflow file.
Please let me know your preference.

@FollowTheProcess
Copy link
Collaborator

I'd say only run on push to main or when there are changes in the action.

Yep sounds good to me!

I think a separate workflow file makes the most sense to me, that way we have one for the main project and one to test the GitHub action

@mayeut mayeut force-pushed the fix-action-ubuntu18.04 branch from 0c4540d to 78fd717 Compare May 7, 2022 08:41
@mayeut
Copy link
Contributor Author

mayeut commented May 7, 2022

I'd say only run on push to main or when there are changes in the action.

Well, GitHub doesn't allow to do an "OR filter" for push so I used main and **action** for branch name on push.

mayeut added 2 commits May 7, 2022 14:44
Always install nox with python3.10 in order to allow
using the action with an ubuntu-18.04 runner.
@mayeut mayeut force-pushed the fix-action-ubuntu18.04 branch from 78fd717 to d4e9436 Compare May 7, 2022 12:45
@FollowTheProcess FollowTheProcess merged commit 6430a34 into wntrblm:main May 10, 2022
@FollowTheProcess
Copy link
Collaborator

Thanks @mayeut 🎉

@mayeut mayeut deleted the fix-action-ubuntu18.04 branch May 15, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants