You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we can set retry_log_level: :debug | :info | ... | false. Besides log level it would be nice to format the log message and I think we can achieve this with deprecating this option in favour of:
retry_log: :debug|:info|...|:emergency|fun|false
where fun is f(request, response_or_exception) :: term(), that is, one would call say Logger.error(custom_message) themselves for maximum flexibility.
If accepted, we'd do similar for retry though there the contract would most likely be f(request, response, location) as we do some additional normalisation.
That being said, retry is by far the most complicated step at the moment so ideally I'd not make it even more so, if there is another way to solve this problem. There is also the matter of #341 (comment).
The text was updated successfully, but these errors were encountered:
Currently we can set
retry_log_level: :debug | :info | ... | false
. Besides log level it would be nice to format the log message and I think we can achieve this with deprecating this option in favour of:where
fun
isf(request, response_or_exception) :: term()
, that is, one would call sayLogger.error(custom_message)
themselves for maximum flexibility.If accepted, we'd do similar for
retry
though there the contract would most likely bef(request, response, location)
as we do some additional normalisation.That being said, retry is by far the most complicated step at the moment so ideally I'd not make it even more so, if there is another way to solve this problem. There is also the matter of #341 (comment).
The text was updated successfully, but these errors were encountered: