Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update rate issues in some hosts #26

Closed
pdesaulniers opened this issue Feb 15, 2018 · 9 comments
Closed

Fix update rate issues in some hosts #26

pdesaulniers opened this issue Feb 15, 2018 · 9 comments
Labels
enhancement New feature or request

Comments

@pdesaulniers
Copy link
Member

For example, the UI feels very unresponsive in Ardour.

@pdesaulniers pdesaulniers changed the title Fix refresh rate issues in some hosts Fix update rate issues in some hosts Feb 17, 2018
@pdesaulniers pdesaulniers added the enhancement New feature or request label Feb 17, 2018
@pdesaulniers pdesaulniers added this to the Version 1.0 milestone Feb 17, 2018
@ghost
Copy link

ghost commented Feb 18, 2018

If i understand it correctly, same in bitwig 1.

@pdesaulniers
Copy link
Member Author

pdesaulniers commented Feb 18, 2018

Yup, it's very blocky in bitwig as well.

The rendering in DPF seems bound to the host's update rate, so we'd have to put the rendering on its own thread somehow. Haven't looked into it yet. Helm is one plugin that doesn't depend on the update
rate.

The UI is pretty fluid in jalv (LV2 host) at a rate of 60:

jalv.gtk -r 60 "https://github.com/pdesaulniers/spoonie-waveshaper"

@pdesaulniers
Copy link
Member Author

pdesaulniers commented Feb 22, 2018

OK, the UI should be smoother now :) My fix needs some more testing, though.

@pdesaulniers
Copy link
Member Author

Could you confirm that my fix doesn't make bitwig explode on your computer, just so I can feel confident closing this issue? :)

@ghost
Copy link

ghost commented Feb 22, 2018

sure; can try today (in 1 to 6 hours)

@ghost
Copy link

ghost commented Feb 22, 2018

works fine

@pdesaulniers
Copy link
Member Author

pdesaulniers commented Feb 22, 2018

Sweet, closing this.

If ever the plugin makes some host crash, then this could be the culprit :p

@pdesaulniers
Copy link
Member Author

pdesaulniers commented May 11, 2018

Unfortunately, that fix caused some users to get a completely black UI. I still feel like it should be fluid in all hosts.

@pdesaulniers pdesaulniers reopened this May 11, 2018
@pdesaulniers pdesaulniers removed this from the Version 1.0 milestone Jan 8, 2021
@pdesaulniers
Copy link
Member Author

Let's forget this. AFAIK, running the UI on a separate thread would require some crazy error-prone hacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant