Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters #50

Open
pdesaulniers opened this issue Mar 13, 2018 · 2 comments
Open

Add filters #50

pdesaulniers opened this issue Mar 13, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@pdesaulniers
Copy link
Member

No description provided.

@pdesaulniers pdesaulniers added this to the Version 1.0 milestone Mar 13, 2018
@pdesaulniers pdesaulniers changed the title Add some filtering options?? Add some filtering options Apr 17, 2018
This was referenced Apr 17, 2018
Closed
Closed
@pdesaulniers pdesaulniers modified the milestones: Version 1.0, Version 2.0 Aug 5, 2018
@pdesaulniers pdesaulniers modified the milestones: Version 2.0, Version 1.0 Dec 17, 2018
@pdesaulniers
Copy link
Member Author

pdesaulniers commented Dec 17, 2018 •
edited
Loading

First, we need some way to expose the filters in the UI.

@pdesaulniers pdesaulniers reopened this Sep 29, 2020
@pdesaulniers pdesaulniers changed the title Add some filtering options Add some filters Sep 29, 2020
@pdesaulniers pdesaulniers added enhancement New feature or request and removed missing feature labels Sep 29, 2020
@pdesaulniers pdesaulniers removed this from the Version 1.0 milestone Jan 8, 2021
@pdesaulniers
Copy link
Member Author

pdesaulniers commented Sep 18, 2021 •
edited
Loading

To implement this feature:

  1. Revert c386087 and 2dd2482
  2. Add three tabs at the bottom of the UI: | PRE FILTER ⏻ | DISTORTION ⏻ | POST FILTER ⏻ |
  3. When the user clicks on either PRE FILTER or POST FILTER, replace the parameters at the bottom of the UI with the following:
    • TYPE (dropdown)
    • CUTOFF (knob)
    • RESONANCE (knob)
    • WET (knob)
  4. When the user clicks on the ⏻ buttons at the right of the tabs, toggle the effect. By default, distortion should be enabled, pre and post filter should be disabled. Incidentally, this would fix [Feature request] a bypass button #99
  5. Display the filters' frequency response in the graph. I think this could be implemented later.

@pdesaulniers pdesaulniers changed the title Add some filters Add filters Sep 19, 2021
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pdesaulniers